search

mozilla / cubeb-coreaudio-rs

The audio backend of Firefox on Mac OS X.
ISC License
25 stars 10 forks source link

Add GitHub Action workflows #128

Closed ChunMinChang closed 3 years ago

ChunMinChang commented 3 years ago

Circle-CI won't run its build and tests for the PR request, but we can use Github-Action to do this. Another benefit I found is that the Mac OS server for Github-Action has a built-in audio device (Soundflower, actually). All the device-related tests can be fully tested on the server.

nils-ohlmeier commented 3 years ago

@ChunMinChang we ran across the same issue of no Circle-CI runs for PR's, but according to this tweet that is only a configuration issue: https://twitter.com/zmarkan/status/1367827983457779716

ChunMinChang commented 3 years ago

@ChunMinChang we ran across the same issue of no Circle-CI runs for PR's, but according to this tweet that is only a configuration issue: https://twitter.com/zmarkan/status/1367827983457779716

I've turned it on yesterday, but it doesn't seem to work. At least, I don't see it runs for this PR

Screen Shot 2021-03-08 at 9 29 42 PM
ChunMinChang commented 3 years ago

I might need to do this: https://circleci.com/docs/2.0/enable-checks/ as well to make it work for PR. I'll try tomorrow. However, it's worth using Github-Action since the Github-Action server has a built-in audio device, while the Circle-CI server has not.

kinetiknz commented 3 years ago

I used GitHub Actions for the other cubeb repos, also finding Soundflower available for macOS tests.

The actions here look good, but as I understand it actions-rs and other external actions are generally not available inside the mozilla GitHub org for security reasons. The Settings -> Actions page for each repo shows: image

cubeb-pulse-rs has a fairly simple working build action without actions-rs, if you'd like to base an action on that.

ChunMinChang commented 3 years ago

@kinetiknz : I've updated the GitHub Actions setting. Would you mind taking a look?