search

mozilla / cubeb-coreaudio-rs

The audio backend of Firefox on Mac OS X.
ISC License
25 stars 10 forks source link

Disable automatic device switching if user doesn't follow the system default device #150

Closed ChunMinChang closed 2 years ago

ChunMinChang commented 2 years ago

To unblock BMO 1735201 and BMO 1238038, CUBEB_STREAM_PREF_DISABLE_DEVICE_SWITCHING needs to be implemented in this crate.

ChunMinChang commented 2 years ago

We should fix #149 first. Then the code would be simpler I guess.

ChunMinChang commented 2 years ago

Instead of adding a pref for cubeb, I think it would be better to "disable automatic device switching" by default unless users ask to follow the system default device. That should be the default behavior in Firefox.

padenot commented 2 years ago

Then we need to add a flag to ask to follow default devices, right ?

ChunMinChang commented 2 years ago

Then we need to add a flag to ask to follow default devices, right ?

I think using nullptr for the device id, as what we do now, is enough.

ChunMinChang commented 2 years ago

Resolved by #154