search

mozilla / cubeb-coreaudio-rs

The audio backend of Firefox on Mac OS X.
ISC License
25 stars 10 forks source link

Use the new async logging macros, fix various log messages #176

Closed padenot closed 2 years ago

padenot commented 2 years ago

This won't build for now, we need to bump cubeb-backend's version here after merging https://github.com/mozilla/cubeb-rs/pull/70, but should be an easy rebase. It works well locally when overriding.

I took the opportunity to fix the phrasing of some logs while I was verifying what type they should be.

ashleyz commented 2 years ago

Just a heads-up that mozilla/cubeb-rs#70 has been merged with the version updated to 0.10.1, so this PR should build once the version numbers here have been updated. Please let me know if you run into any issues, thanks!

ChunMinChang commented 2 years ago

We got a compiler error with Rust Nightly. See https://github.com/rust-lang/rust/issues/99563

ChunMinChang commented 2 years ago

We got a compiler error with Rust Nightly. See rust-lang/rust#99563

https://github.com/rust-lang/rust/pull/99893 shoudl fix this

padenot commented 2 years ago

@ChunMinChang, I've updated this based on your fix and fixed a nightly-only clippy issue, please take another look!