mozilla / cubeb-coreaudio-rs

The audio backend of Firefox on Mac OS X.
ISC License
25 stars 10 forks source link

Run the tests in the subcrate #51

Closed ChunMinChang closed 4 years ago

ChunMinChang commented 4 years ago

The test in the sub-crate, coreaudio-sys-utils, aren't run in both local device and Travis CI server. Those tests in the coreaudio-sys-utils should also be run with the sanitizers. It will be easier to identify the problem (if any) is in the underlying system API implemented in the sub-crate, or it's in the main crate, by running the tests in the sub crate.

Running those tests is helpful to diagnose the problem, or narrow down the scope of the problem at least. For example, there are memory leaks found by running MemorySanitier with the tests in the coreaudio-sys-utils. It indicates the memory is leaking when calling the underlying APIs. It's helpful to address the leak issue found in #45.

On the other hand, the format check and the lints/clippy check should always be run, instead of running in Travis CI server only. It makes sure every commit follows the Rust coding style properly.