search

mozilla / cubeb-coreaudio-rs

The audio backend of Firefox on Mac OS X.
ISC License
25 stars 10 forks source link

Test passed when `cargo clippy -- -D warnings` fails #60

Closed ChunMinChang closed 4 years ago

ChunMinChang commented 4 years ago

My terminal gives a warning when running the update introduced by #57 as follows, but the Travis server doesn't fail.

We should make cargo clippy -- -D warnings work.

chang@cchang-37365 cubeb-coreaudio-rs % cargo clippy -- -D warnings                                                                    < (git) pr-57
    Checking cubeb-coreaudio v0.1.0 (/Users/cchang/Work/cubeb-coreaudio-rs)
error: unused variable: `frames_written`
   --> src/backend/mod.rs:659:17
    |
659 |             let frames_written = stm.frames_written.load(Ordering::SeqCst);
    |                 ^^^^^^^^^^^^^^ help: consider prefixing with an underscore: `_frames_written`
    |
    = note: `-D unused-variables` implied by `-D warnings`

error: aborting due to previous error

error: could not compile `cubeb-coreaudio`.

To learn more, run the command again with --verbose.