search

mozilla / cubeb-coreaudio-rs

The audio backend of Firefox on Mac OS X.
ISC License
25 stars 10 forks source link

Fix the resampler-calling code to use the correct semantic #71

Closed padenot closed 4 years ago

padenot commented 4 years ago

The resampler copies all the frames into its internal buffer regardless of the value it returns. Because we need to keep track of the buffer depths in this backend to avoid growing the latency between input and output, we only give the resampler enough data to work with.

padenot commented 4 years ago

I've pushed an update with comments addressed and ran cargo fmt.

ChunMinChang commented 4 years ago

I've pushed an update with comments addressed and ran cargo fmt.

Is it supposed to have some differences between https://github.com/ChunMinChang/cubeb-coreaudio-rs/commit/55fd4bf0ca31febba9f59fb20d7c3d5bd8237fcf and https://github.com/ChunMinChang/cubeb-coreaudio-rs/commit/d49a6c6fe8a6a8fe5632f1a70a8464921d37114b? The only difference I see is the commit-id.

The style-check still fails on Travis CI server: https://travis-ci.org/github/ChunMinChang/cubeb-coreaudio-rs/jobs/668918572

padenot commented 4 years ago

Yes, pushed the wrong one it seems like.