Don't really push silence to the ring buffer

mozilla / cubeb-coreaudio-rs

The audio backend of Firefox on Mac OS X.

ISC License

25 stars 10 forks source link

Don't really push silence to the ring buffer #86

Closed padenot closed 4 years ago

padenot commented 4 years ago

This implements your idea, only by removing code it turns out.

padenot commented 4 years ago

I've tested it on a few devices on my macbook 2018: built-in speakers/mic, an hd25 plugged in the TRRS socket(it doesn't have a mic), and a Sony WH-1000 xm3, that has a mic, via bluetooth, and trying all sorts of combinations and switches.

ChunMinChang commented 4 years ago

Add a reference: This fixes BMO 1629839.