@kinetiknz, could you just pass your eye over these fixes. try_from was wrong for SinkFlags (It was checking SourceFlags). Unfortunately, neither my local testing, nor try push picked up the issue.
I've removed the expect() call. Causing panics is too risky, it brings down the whole process. Really, we should log any unknown flags, but not crash.
@kinetiknz, could you just pass your eye over these fixes. try_from was wrong for SinkFlags (It was checking SourceFlags). Unfortunately, neither my local testing, nor try push picked up the issue.
I've removed the expect() call. Causing panics is too risky, it brings down the whole process. Really, we should log any unknown flags, but not crash.