search

mozilla / cubeb-pulse-rs

ISC License
16 stars 17 forks source link

Stable cubeb_devid (based on kinetiknz/cubeb#299) #18

Closed kinetiknz closed 7 years ago

kinetiknz commented 7 years ago

Implements the string interning approach already used in kinetiknz/cubeb#299 to provide the same lifetime guarantee for cubeb_devids in the Rust implementation.

Also includes a couple of other minor fixes.

Opening PR early to track this, but it might not be ready to review/merge yet. Feel free to comment on it, though.

Pushed to try here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5531dafbabdbddc3ec4bf97efb4c5f188807fa2a

kinetiknz commented 7 years ago

@padenot FYI (since you were interested in this), this needs to be merged before you can rely on stable cubeb_devids in Gecko, since we're using this backend in favour of the cubeb_pulse.c one.

kinetiknz commented 7 years ago

@djg I think this is good to go now. Please review and merge if it looks good.