Open nox opened 6 years ago
Some issues I found:
Context
&mut self
Context::unref
Drop
Context::clear_state_callback
Context::set_state_callback
*mut c_void
Context::connect
0xdeadbeef as *const _
api
Context::drain
Context::rttime_new
Context::get_server_info
Context::get_sink_info_by_name
Context::get_sink_info_list
Context::get_sink_input_info
Context::get_source_info_list
Context::set_seek_input_volume
Context::subscribe
Context::clear_subscribe_callback
Context::set_subscribe_callback
MainloopApi
MainloopApi::once
MainloopApi::time_free
0xdeadbeef as *mut _
e
Stream
Stream::unref
Stream::begin_write
Stream::write
data
Stream::drop
Stream::update_timing_info
Stream::clear_state_callback
Stream::set_state_callback
Stream::clear_write_callback
Stream::set_write_callback
Stream::clear_read_callback
Stream::set_read_callback
Stream::cork
ThreadedMainloop
ThreadedMainloop::is_null
More stuff will probably surface once we start handling these.
Some issues I found:
Context
methods should take a&mut self
receiver;Context::unref
should be aDrop
implementation;Context::clear_state_callback
;Context::set_state_callback
should be made to not need a*mut c_void
parameter;Context::connect
should be unsafe (can pass0xdeadbeef as *const _
for itsapi
argument);Context::drain
should be made to not need a*mut c_void
parameter;Context::rttime_new
should be made to not need a*mut c_void
parameter;Context::get_server_info
should be made to not need a*mut c_void
parameter;Context::get_sink_info_by_name
should be made to not need a*mut c_void
parameter;Context::get_sink_info_list
should be made to not need a*mut c_void
parameter;Context::get_sink_input_info
should be made to not need a*mut c_void
parameter;Context::get_source_info_list
should be made to not need a*mut c_void
parameter;Context::set_seek_input_volume
should be made to not need a*mut c_void
parameter;Context::subscribe
should be made to not need a*mut c_void
parameter;Context::clear_subscribe_callback
;Context::set_subscribe_callback
should be made to not need a*mut c_void
parameter;MainloopApi
methods should take a&mut self
receiver;MainloopApi::once
should be made to not need a*mut c_void
parameter;MainloopApi::time_free
should be unsafe (can pass0xdeadbeef as *mut _
for itse
argument);Stream
methods should take a&mut self
receiver;Stream::unref
should be aDrop
implementation;Stream::begin_write
should probably return a safe wrapper instead of a raw pointer;Stream::begin_write
can be called again before completion of last write;Stream::write
should be unsafe (can pass0xdeadbeef as *mut _
for itsdata
argument);Stream::drop
is an intrinsic method and not an actualDrop
implementation;Stream::update_timing_info
should be made to not need a*mut c_void
parameter;Stream::clear_state_callback
;Stream::set_state_callback
should be made to not need a*mut c_void
parameter;Stream::clear_write_callback
;Stream::set_write_callback
should be made to not need a*mut c_void
parameter;Stream::clear_read_callback
;Stream::set_read_callback
should be made to not need a*mut c_void
parameter;Stream::cork
should be made to not need a*mut c_void
parameter;ThreadedMainloop
methods should take a&mut self
receiver;ThreadedMainloop::is_null
is needed (AFAICT the pointer should not be null ever).More stuff will probably surface once we start handling these.