search

mozilla / cubeb-rs

ISC License
61 stars 19 forks source link

Add a new enum binding #41

Closed padenot closed 5 years ago

padenot commented 5 years ago

In line with the changes at https://github.com/kinetiknz/cubeb/pull/501.

How can we get this into gecko? Is it necessary to make a release and to bump the manifest and to re-vendor or something? Do we have instructions to do this?

This change is Reviewable

padenot commented 5 years ago

@kinetiknz, @djg, if you can have a look?

kinetiknz commented 5 years ago

Is it necessary to make a release and to bump the manifest and to re-vendor or something?

Yeah, sadly. And that requires push access to crates.io. Need to get around to merging the various cubeb/audioipc repos and dropping Gecko dependency on the crates.io stuff.

For this patch, I think we can get away with not updating cubeb-rs in Gecko for now - we're not using CUBEB_STREAM_PREF_VOICE in the Rust code yet.

djg commented 5 years ago

Sorry that's my fault. Dealing with vendoring rust into gecko used to be a huge pain-in-the-arse and publishing to crates.io was easier.

On Thu, 11 Apr 2019 at 07:43, Matthew Gregan notifications@github.com wrote:

Is it necessary to make a release and to bump the manifest and to re-vendor or something?

Yeah, sadly. And that requires push access to crates.io. Need to get around to merging the various cubeb/audioipc repos and dropping Gecko dependency on the crates.io stuff.

For this patch, I think we can get away with not updating cubeb-rs in Gecko for now - we're not using CUBEB_STREAM_PREF_VOICE in the Rust code yet.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/djg/cubeb-rs/pull/41#issuecomment-481878707, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJhrWva4XQoQsfQivizTTZzmdFudoQjks5vflsRgaJpZM4cnumQ .

-- Dan Glastonbury, Dan dot Glastonbury at gmail dot com `Pour encourjay lays ortras'