search

mozilla / cubeb-rs

ISC License
61 stars 19 forks source link

Fix infinite loop in StreamBuilder::new()/default() #59

Closed Manorhos closed 2 years ago

Manorhos commented 2 years ago

This bug was intruduced in 7c9c659.

Manorhos commented 2 years ago

I would've used that, but due to rust#26925 MonoFrame and StereoFrame would need to implement Default as well. This wouldn't be completely trivial though, as for unsigned sample types you'd probably want equilibrium as the default and not 0, so we couldn't just derive Default there.

kinetiknz commented 2 years ago

Thanks for fixing my silly mistake!