search

mozilla / cubeb

Cross platform audio library
ISC License
440 stars 124 forks source link

Make use of AudioHardwareCreateAggregateDevice API available after 10.9 #244

Open achronop opened 7 years ago

achronop commented 7 years ago

PR #231 implementing aggregate device for audiounit backend. The create/destroy of a aggregate device can be simplified by using the AudioHardwareCreateAggregateDevice(), AudioHardwareDestroyAggregateDevice() methods. They are available after 10.9. Cubeb does not need to support earlier version of macOS.

achronop commented 7 years ago

In addition use this bug to implement 2 left over comments: comment 1 and comment 2

kinetiknz commented 7 years ago

This was landed in https://github.com/kinetiknz/cubeb/commit/edac47d845c91cff5b77c95fcbcffc6d2666098a and then reverted in https://github.com/kinetiknz/cubeb/commit/991c98df805d954d09ddca837ec7556af08996a0 because Gecko's builders are stuck on 10.7 for now. We'll need to revisit this once the builders have been updated.

See also: https://github.com/kinetiknz/cubeb/pull/247#issuecomment-284683659