This modifies the starting example so that it will compile and run as-is. (The new user experience is discouraging when the starting example requires multiple changes and digging through documentation, and this addresses that.)
The git diff is messed up because it is embedded inside a comment. Here is a more readable diff, with explanations.
When the user doesn't have a microphone, the starting example fails to run, with little indication of what the problem is. I added a flag which switches the behavior to output-only. Above the code, I also added a comment to explain the failure: "If you receive "Could not open the stream", you likely do not have a microphone. In that case, change PIPE_INPUT_TO_OUTPUT from true to false."
I left the input-to-output behavior as the default out of conservativeness for this patch. You can switch #define PIPE_INPUT_TO_OUTPUT true to false, to choose an output-only default. This would be more likely to run on the first try.
long data_cb(cubeb_stream * stm, void * user,
const void * input_buffer, void * output_buffer, long nframes)
{
- const float * in = input_buffer;
- float * out = output_buffer;
+ const float * in = (float *)input_buffer;
+ float * out = (float *)output_buffer;
C++ doesn't allow this implicit conversion, whereas C does. This helps it compile in C++ without affecting C.
for (int i = 0; i < nframes; ++i) {
for (int c = 0; c < 2; ++c) {
+ #if PIPE_INPUT_TO_OUTPUT
out[2 * i + c] = in[i];
+ #else
+ out[2 * i + c] = (float)((i * 123) % 200) / 10000.f;
+ #endif
This is the fallback I chose when the input-to-output behavior is disabled. It is a buzzy tone that doesn't sound great. I chose this one because it is simple and doesn't add state; more conventional tones like sines or sawtooth would run up against the buffer size boundary, creating a sharp jump. With this modulo tone, the sharp jumps are part of the tone, so the buffer boundaries are not noticeable.
COM issues were hard to diagnose and fix when I first tried cubeb a while back; this removes that problem for the new user example. The existing documentation was not in a place that is easy for new users to find quickly. I don't know about the experience now.
Also, the callbacks have been shuffled to above main(), to form a single file that can be used as-is. I wrote the compilation command for g++ (msys2), and left the user to figure out Visual Studio.
This modifies the starting example so that it will compile and run as-is. (The new user experience is discouraging when the starting example requires multiple changes and digging through documentation, and this addresses that.)
The git diff is messed up because it is embedded inside a comment. Here is a more readable diff, with explanations.
This adds the necessary headers.
When the user doesn't have a microphone, the starting example fails to run, with little indication of what the problem is. I added a flag which switches the behavior to output-only. Above the code, I also added a comment to explain the failure: "If you receive "Could not open the stream", you likely do not have a microphone. In that case, change PIPE_INPUT_TO_OUTPUT from true to false."
I left the input-to-output behavior as the default out of conservativeness for this patch. You can switch
#define PIPE_INPUT_TO_OUTPUT trueto false, to choose an output-only default. This would be more likely to run on the first try.C++ doesn't allow this implicit conversion, whereas C does. This helps it compile in C++ without affecting C.
This is the fallback I chose when the input-to-output behavior is disabled. It is a buzzy tone that doesn't sound great. I chose this one because it is simple and doesn't add state; more conventional tones like sines or sawtooth would run up against the buffer size boundary, creating a sharp jump. With this modulo tone, the sharp jumps are part of the tone, so the buffer boundaries are not noticeable.
COM issues were hard to diagnose and fix when I first tried cubeb a while back; this removes that problem for the new user example. The existing documentation was not in a place that is easy for new users to find quickly. I don't know about the experience now.
My Windows did not have sleep(), so I used Sleep() instead.
Also, the callbacks have been shuffled to above main(), to form a single file that can be used as-is. I wrote the compilation command for g++ (msys2), and left the user to figure out Visual Studio.