mozilla / cubeb

Cross platform audio library
ISC License
439 stars 124 forks source link

New warnings related to copy elision in `cubeb_wasapi.cpp` #733

Closed padenot closed 1 year ago

padenot commented 1 year ago
 0:19.32 C:/Users/paden/mozilla-unified/media/libcubeb/src/cubeb_wasapi.cpp(2502,13): warning: unqualified call to 'std::move' [-Wunqualified-std-cast-call]
 0:19.32             move(copy_wide_string(stm->output_device_id.get()))) {
 0:19.32             ^
 0:19.32             std::
 0:19.32 C:/Users/paden/mozilla-unified/media/libcubeb/src/cubeb_wasapi.cpp(2502,13): warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
 0:19.32 C:/Users/paden/mozilla-unified/media/libcubeb/src/cubeb_wasapi.cpp(2502,13): note: remove std::move call here
 0:19.32             move(copy_wide_string(stm->output_device_id.get()))) {
 0:19.32             ^~~~~                                             ~
 0:19.32 C:/Users/paden/mozilla-unified/media/libcubeb/src/cubeb_wasapi.cpp(2503,35): warning: unqualified call to 'std::move' [-Wunqualified-std-cast-call]
 0:19.32       selected_output_device_id = move(tmp);
 0:19.32                                   ^
 0:19.32                                   std::
 0:19.32 C:/Users/paden/mozilla-unified/media/libcubeb/src/cubeb_wasapi.cpp(2545,13): warning: unqualified call to 'std::move' [-Wunqualified-std-cast-call]
 0:19.32             move(utf8_to_wstr(reinterpret_cast(matched)));
 0:19.32             ^
 0:19.32             std::
 0:19.32 C:/Users/paden/mozilla-unified/media/libcubeb/src/cubeb_wasapi.cpp(2545,13): warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
 0:19.32 C:/Users/paden/mozilla-unified/media/libcubeb/src/cubeb_wasapi.cpp(2545,13): note: remove std::move call here
 0:19.32             move(utf8_to_wstr(reinterpret_cast(matched)));
 0:19.32             ^~~~~                                                     ~
 0:19.34 C:/Users/paden/mozilla-unified/media/libcubeb/src/cubeb_wasapi.cpp(2561,15): warning: unqualified call to 'std::move' [-Wunqualified-std-cast-call]
 0:19.34               move(copy_wide_string(stm->input_device_id.get()))) {
 0:19.34               ^
 0:19.34               std::
 0:19.34 C:/Users/paden/mozilla-unified/media/libcubeb/src/cubeb_wasapi.cpp(2561,15): warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
 0:19.34 C:/Users/paden/mozilla-unified/media/libcubeb/src/cubeb_wasapi.cpp(2561,15): note: remove std::move call here
 0:19.34               move(copy_wide_string(stm->input_device_id.get()))) {
 0:19.34               ^~~~~                                            ~
 0:19.34 C:/Users/paden/mozilla-unified/media/libcubeb/src/cubeb_wasapi.cpp(2563,37): warning: unqualified call to 'std::move' [-Wunqualified-std-cast-call]
 0:19.34         selected_output_device_id = move(tmp);
 0:19.34                                     ^
 0:19.34                                     std::