mozilla / cubeb

Cross platform audio library
ISC License
440 stars 124 forks source link

In test_duplex loop back all input frames #765

Closed Pehrsons closed 11 months ago

Pehrsons commented 11 months ago

The break removed here makes sense for input-only, where breaking has no side effects. In a loopback duplex case like here it makes the callback exit early, before having written all frames. This can be caused by clipping on the input side (as observed on MacOS) and creates a distortion that sounds terrible.