Clamp to positive value when computing latency for an output stream

mozilla / cubeb

Cross platform audio library

ISC License

434 stars 123 forks source link

Clamp to positive value when computing latency for an output stream #786

Closed padenot closed 1 month ago

padenot commented 2 months ago

Diagnosed by jolin@mozilla.com, the same code is also found in Chromium.

@jhlin r? (I'm not sure how to flag you as reviewer on GitHub).

jhlin commented 2 months ago

LGTM. r+.

jhlin commented 2 months ago

@kinetiknz I uploaded the patch to the try server and got build breaks for 64-bit Android targets while all GitHub checks passed. Are build-android 32-bit targets only?

padenot commented 2 months ago

Fixed in more recent patches, if you can take another look @jhlin ? Commit 2d8568a made it reproduce the failure you saw on Treeherder, and then the two subsequent commits fixed it.