search

mozilla / debug-ping-view

Glean Debug Ping Viewer
Mozilla Public License 2.0
5 stars 2 forks source link

Fix bug in Event Stream when you filter down to only a single event #116

Closed rosahbruno closed 4 months ago

rosahbruno commented 11 months ago

Steps to reproduce

  1. View an event stream for a debug tag
  2. Select something like last 15 minutes for a tag that only has 1 event in that timeframe

Actual: The event timeline goes away and only displays details about the single event. Expected: The event timeline should stay and only that one event should be shown.

Context

There is a component where this is controlled (src/components/Events/index.js). This component has a flag called isEventStream. We need to conditionalize the single event behavior to always show the timeline whenever we are viewing the event stream.

Demo

https://github.com/mozilla/debug-ping-view/assets/24759139/4ed8b818-7747-4671-b364-a37c52a8fef3

rosahbruno commented 4 months ago

After thinking about this more, this is fine how it is. Not really worth changing.