search

mozilla / delivery-console

Normandy recipe editor
Mozilla Public License 2.0
13 stars 22 forks source link

Fix typo for filter object validation message #1123

Closed uhlissuh closed 4 years ago

uhlissuh commented 4 years ago

I was looking at Delivery Console today for something and noticed this typo... figured I'd fix it for fun to open my first pull request on another project in our team stack. If this is indeed a typo...

uhlissuh commented 4 years ago

@rehandalal I can't tell if this linting error is related to my tiny lil' change...?

rehandalal commented 4 years ago

@rehandalal I can't tell if this linting error is related to my tiny lil' change...?

It is unrelated and fixed in #1124

bors[bot] commented 4 years ago

:v: uhlissuh can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

rehandalal commented 4 years ago

once the other PR merges you should be able to do a "bors r+" here and it will merge this one

no rebase or merging in master necessary

rehandalal commented 4 years ago

@uhlissuh for future reference PRs should be merged on this project using "bors r+" not the merge button (i've added protections on master so this will not be possible any longer) and you don't need to do a rebase or merge in master unless there are merge conflicts