mozilla / django-badger

django-badger is a reusable Django app for creating and awarding badges. See also badges.mozilla.org
https://github.com/mozilla/django-badger
BSD 3-Clause "New" or "Revised" License
117 stars 61 forks source link

Consider restricing characters for tag names #129

Open lmorchard opened 11 years ago

lmorchard commented 11 years ago

Currently, badges can be given a tag named like <h1>foo</h1>. This did trigger an error, which was fixed by allowing slashes in tag names.

However, even though the HTML is properly escaped when displayed, we may want to consider rejecting or filtering tag names with what looks like HTML data.

But, I'd like to be generous in what's allowed in tag names. Sometimes using slashes, spaces, colons, and other punctuation can be useful in building tagging schemes.