search

mozilla / django-badger

django-badger is a reusable Django app for creating and awarding badges. See also badges.mozilla.org
https://github.com/mozilla/django-badger
BSD 3-Clause "New" or "Revised" License
117 stars 61 forks source link

Direct claim URLs no longer work #140

Closed Sheeri closed 11 years ago

Sheeri commented 11 years ago

I know they worked last week, but they're not seeming to work this week.

I used to be able to direct people to:

https://badgus-dev.allizom.org/en-US/badges/claim/[code] for example https://badgus-dev.allizom.org/en-US/badges/claim/mxmehp

But that's no longer working, and it redirects me to (I think) the page for the last person to get the award: https://badgus-dev.allizom.org/en-US/badges/badge/MySQL_Marinate_Week_3_Complete/awards/99

I have to tell people to go to https://badgus-dev.allizom.org and enter the claim code, but that's silly....the claim URL stopped working...silently....with a redirect to an unhelpful page? If anything, it should redirect you to a page that says something like "please enter claim code [code] into the box at https://badgus-dev.allizom.org".

lmorchard commented 11 years ago

Wifi at the AUS airport is trolling me, so I can't quite get to the site and check on this myself in admin, but:

This sounds exactly like how single-use claim codes are meant to work. That is, once one is claimed, subsequent claim attempts just turn into a redirect to the award into which the claim was converted. Maybe double check that your claim code leads to a reusable claim, rather than a single-use?

Sheeri commented 11 years ago

It's a reusable code, it's been reused several times already. I double-checked and when I go to the badge page, it shows that it's a reusable code (not a one-time code).

lmorchard commented 11 years ago

Okay, sure enough: I can reproduce this and the claim code is indeed flagged as reusable. The form on the front page works when a code's pasted in, but yeah the claim URL should lead to a form to confirm claiming the code.