search

mozilla / django-badger

django-badger is a reusable Django app for creating and awarding badges. See also badges.mozilla.org
https://github.com/mozilla/django-badger
BSD 3-Clause "New" or "Revised" License
117 stars 61 forks source link

Changing badge title does not update the badge slug #147

Open lmorchard opened 11 years ago

lmorchard commented 11 years ago

I changed the title to a bug, but the slug remained the same. The slug should change.

lmorchard commented 11 years ago

Hmm, actually I wonder if I did this on purpose: The code only sets a slug the first time, and I might have done it that way so that renaming a badge doesn't break existing links to awards and things.

lmorchard commented 11 years ago

Oh, this is trickier than I thought: I didn't want to rigidly tie slug to title, because programmatically created badges need more freedom in using slugs as IDs. Need to revert this "fix"

lmorchard commented 11 years ago

https://github.com/lmorchard/django-badger/commit/963f2ffe452a94fae8bf9d5f405abdb016f22988