search

mozilla / django-browserid

Django application for adding BrowserID support.
Mozilla Public License 2.0
179 stars 80 forks source link

Log/raise an error of some kind if browserid-info isn't on a page with the JavaScript #161

Closed Osmose closed 11 years ago

Osmose commented 11 years ago

Flicks recently ran into an error state where a user would log into Flicks, then log out from persona.org, and not be able to log out of Flicks. This was because the user didn't have an active Persona session, so navigator.id.logout wasn't running the onlogout handler. Why did the user have an active Flicks session without an active Persona session? Flicks didn't have browserid_info in the base template, of course!

I can't think of a situation where you want to include the JS on the page but not include browserid_info, so I think we should make the JS file log or throw some sort've error if it can't find browserid-info.

Osmose commented 11 years ago

This isn't valid anymore now that we want to get rid of browserid-info as per #198 .