mozilla / django-browserid

Django application for adding BrowserID support.
Mozilla Public License 2.0
179 stars 80 forks source link

easy_install doesn't work #163

Closed andresriancho closed 11 years ago

andresriancho commented 11 years ago

I know that the documentation states that django-browserid needs to be installed using pip install but during the development of a tool a friend of mine used easy_install instead; which lead to lots of problems.

The problem with easy_install is that it will install the browserid module as an egg (zip) inside the python directory. Everything works great with the python imports; but when you really want to use the module in a django app it will fail to find the template files (because they are not real files, they are bits inside the zip).

This might be an easy_install or django-browserid problem; I don't really know but you should be aware of it and potentially fix the way you package your software so that both easy_install and pip work as expected.

Osmose commented 11 years ago

Hmmm, I'm no packaging expert, but I would definitely like to see if we can get it to work with easy_install if it isn't too hard to do.

I'm adding this to the 0.9 milestone. Hopefully me or someone else will be able to take a look at this soon. Thanks for the report!

peterbe commented 11 years ago

Will this be solved if we add zip_safe=False to setup()?

andresriancho commented 11 years ago

Would be inclined to answer: yes.

peterbe commented 11 years ago

http://bashelton.com/2009/04/setuptools-tutorial/#advanced_options-zip_safe

peterbe commented 11 years ago

Or you can tell your friend to use easy_install -Z django-browserid

andresriancho commented 11 years ago

Or he can use pip, like the documentation says, but my worry now is not my friend but all the other users who might try to install this package with easy_install. That's why I think it should be fixed upstream (potentially with zip_safe=False)

peterbe commented 11 years ago

See https://github.com/mozilla/django-browserid/pull/164

Osmose commented 11 years ago

This should be fixed by 47b5eb6cb556acd3ae9496ae3229202a66fb4837.