mozilla / django-browserid

Django application for adding BrowserID support.
Mozilla Public License 2.0
180 stars 80 forks source link

Fix #136: Replace test_verification with new tests in test_base. #171

Closed Osmose closed 11 years ago

Osmose commented 11 years ago

Replaces the out-of-date tests in test_verification with new ones. Also makes a few formatting fixes to base.py.

@willkg r?

willkg commented 11 years ago

This got lost in my inbox. Really sorry about that. I'll look at it today.

willkg commented 11 years ago

I tried to go through the tests meticulously. I don't see anything obviously wrong, but I don't have a crystal clear understanding of the underlying bits to know whether something was subtly wrong. So, r+ with that huge caveat.

willkg commented 11 years ago

Just to reiterate the last comment, r+.