search

mozilla / django-browserid

Django application for adding BrowserID support.
Mozilla Public License 2.0
180 stars 80 forks source link

Fix #196: Add support for BrowserID in the admin interface. #218

Closed Osmose closed 10 years ago

Osmose commented 10 years ago

Also changes browserid_login and browserid_logout to not auto-add the browserid-login/browserid-logout classes to links that they generate, in order to allow code to use the helpers without forcing the buttons to use the login code from browserid.js (the admin utilizes this).

Also also adds some licensing comments that we were missing.

Osmose commented 10 years ago

@peterbe r?

peterbe commented 10 years ago

I'd love to work on this but I've got some vacation coming up so if you expect a review before the new year, perhaps ask around.

Osmose commented 10 years ago

@willkg, I choose you! Use a splash attack!

willkg commented 10 years ago

I can get to this tomorrow (Friday).

I'm not sure how I feel about being a magikarp.

Osmose commented 10 years ago

Maybe a surfing Pikachu?

willkg commented 10 years ago

I wanted to test this on one of my sites (pyvideo, Input, whatever), but can't without a lot of other upgrade work.

This looks ok to me with the minor exception of the name admin_site. If it's not correct, it's the sort of thing we'll discover quickly.

r+