search

mozilla / django-browserid

Django application for adding BrowserID support.
Mozilla Public License 2.0
180 stars 80 forks source link

Change BROWSERID_VERIFY_CLASS log message to not look like an error. #237

Closed Osmose closed 10 years ago

Osmose commented 10 years ago

Ever since BROWSERID_VERIFY_CLASS started logging to the console when it falls back to the default verification backend, people have been mistaking the message (which unfortunately includes a traceback) as a real error and asking how to fix it. In actuality, it's just normal behavior if you don't have a custom verification backend.

We should make the message friendlier, like "Using the default verification backend." and "Using the path.to.custom.backend verification backend." with no traceback.

willkg commented 10 years ago

I wonder why we should be logging anything at all here. If it's got a sane default then using the default seems ok without logging something, right?

Osmose commented 10 years ago

I think I wanted to log it as info because I wanted to be logging more things so that when logging was enabled people got a clearer picture of what django-browserid was doing, but I am not against just tearing it out either.

willkg commented 10 years ago

Fair enough. I think I'd bump it down to DEBUG. Seems like more of a "I'm wondering why it ain't working right, so I will switch to DEBUG logging and see what the tarnation is goin on down there" kind of thing.

willkg commented 10 years ago

(I'm just brainstorming--now that I know what's going on, I don't really mind having it there.)

willkg commented 10 years ago

It'd be nice if it did some ascii art, though. Something like http://knowyourmeme.com/memes/flipping-tables-%E2%95%AF%E2%96%A1%EF%BC%89%E2%95%AF%EF%B8%B5-%E2%94%BB%E2%94%81%E2%94%BB