search

mozilla / django-browserid

Django application for adding BrowserID support.
Mozilla Public License 2.0
180 stars 80 forks source link

Possible popup blocking on login button click #239

Closed Osmose closed 10 years ago

Osmose commented 10 years ago

We've gotten a report of, and I've seen one instance of, login buttons from django-browserid triggered the popup blocking mechanism in Firefox. I suspect that, if there is an issue, it's related to the fact that the JS calls getInfo before triggering the popup, which may cause an AJAX request and possibly lose whatever bit gets set during click events to allow popups to be launched.

willkg commented 10 years ago

I have this problem with richard, too.

willkg commented 10 years ago

So... I have this boo-hiss situation where I need this fixed in richard before the writethedocs conference on Monday.

What can I do to help get this fixed in the next couple of days?

Osmose commented 10 years ago

I've got a patch that fixes this done, am currently writing tests for it, expect a PR in a few hours (I needs food!).

willkg commented 10 years ago

You rock! Thank you!