search

mozilla / django-browserid

Django application for adding BrowserID support.
Mozilla Public License 2.0
180 stars 80 forks source link

Fix #243: Document removal of context processor. #258

Closed Osmose closed 10 years ago

Osmose commented 10 years ago

Also adds a small reminder to Troubleshooting about leftover pyx files.

Osmose commented 10 years ago

@willkg r?

peterbe commented 10 years ago

r+ but "removed" isn't clear enough IMHO.

willkg commented 10 years ago

r+ but "removed" isn't clear enough IMHO.

How would you suggest changing the language so it's clearer?

Osmose commented 10 years ago

Yeah, not sure we can be any clearer than removed, but will change it to something better if you have it.

peterbe commented 10 years ago

"Removed" sounds like something still exists but is no longer visible. "Deleted" on the other hands sounds more like it's been wiped off the face of the earth.

I'm sorry for really blowing up a teacup tornado here. How about:

- Remove ``django_browserid.context_processors.browserid`` from your
  ``TEMPLATE_CONTEXT_PROCESSORS`` setting, as code no longer 
exists and is no longer something you need here.

Really not that important.

Osmose commented 10 years ago

I changed it to "Remove django_browserid.context_processors.browserid from your TEMPLATE_CONTEXT_PROCESSORS setting, as the context processor no longer exists.". I think that's a fair compromise. :D