Fix #140: Add support for offline development via auto-login backend.

mozilla / django-browserid

Django application for adding BrowserID support.

Mozilla Public License 2.0

179 stars 80 forks source link

Fix #140: Add support for offline development via auto-login backend. #262

Closed Osmose closed 10 years ago

Osmose commented 10 years ago

@willkg r?

Also, doh, forgot to document this. Will add that.

willkg commented 10 years ago

The rest of this looks good.

Osmose commented 10 years ago

Updated! :D

Osmose commented 10 years ago

@willkg Is this good to merge?

willkg commented 10 years ago

I think that one issue about the helper is the only outstanding thing. It's possible I'm misreading things. I can't tell. It's been a while since I looked at this.

Osmose commented 10 years ago

After talking a bit on IRC and thinking, I decided it would be better to have a single setting to control if auto-login is enabled, rather than relying on the combination of the authentication backend and the email setting. I've added the BROWSERID_AUTOLOGIN_ENABLED setting and updated the tests and docs accordingly.

willkg commented 10 years ago

I think that looks good. bd. r+ :candy: