search

mozilla / django-browserid

Django application for adding BrowserID support.
Mozilla Public License 2.0
180 stars 80 forks source link

Fix #57: Add local verification via PyBrowserID. #264

Closed Osmose closed 9 years ago

Osmose commented 10 years ago

2 years isn't the worst

Osmose commented 10 years ago

@rfk r? (Mostly just our use of PyBrowserID, willkg can cover other stuff). @willkg r?

Osmose commented 10 years ago

Note that this changes the behavior of our authentication backend; previously it could raise a BrowserIDException, now it catches them, logs them as warnings, and returns None. IMO this is more consistent with how authentication backends work.

And because we don't raise an exception anymore, the view doesn't have to bother with logging them. Yay!

willkg commented 9 years ago

I had one minor issue with the tests, but otherwise this looks ok to me as far as I can tell.