search

mozilla / django-browserid

Django application for adding BrowserID support.
Mozilla Public License 2.0
180 stars 80 forks source link

Disable autologin.js when BROWSERID_AUTOLOGIN_ENABLED = False even if it on the page. #267

Closed Osmose closed 9 years ago

Osmose commented 9 years ago

@bobsilverberg mentioned via email that the docs around disabling auto login are confusing for people not using browserid_js. The issue is that, if you're not using browserid_js, you manually have to remove autologin.js to disable autologin completely, which seemingly contradicts our docs insistence that BROWSERID_AUTOLOGIN_ENABLED controls whether autologin is enabled.

It'd be nice if autologin.js was able to check if the setting is False, and if it is, cancel any monkeypatching it does so that autologin is truly disabled.

willkg commented 9 years ago

I think piling on more code to fix the development environment issue is not the way to go. I'd like to look at improving the docs to cover the "I'm not using browserid_js" case first.

I can take a stab at that this week.