search

mozilla / django-browserid

Django application for adding BrowserID support.
Mozilla Public License 2.0
179 stars 80 forks source link

Rework the auto-login docs #270

Closed willkg closed 10 years ago

willkg commented 10 years ago

I reworked the auto-login docs turning the instructions into lists of steps and breaking up the text into an "enable" section and a "disable" section. I think this is easier to read. It's certainly easier to follow.

Further, I think this addresses the confusion around what happens if you're not using "django_browserid.helpers.browserid_js" regarding "browserid/autologin.js" since it explicitly addresses it in the relevant areas as a discrete step.

Fixes #267

r?

Osmose commented 10 years ago

@bobsilverberg, do these documentation updates make the process clearer for you?

willkg commented 10 years ago

^^^ Fixes issues raised.

bobsilverberg commented 10 years ago

LGTM. It certainly removes the issue that I reported.

Osmose commented 10 years ago

r+, nice work!