Simplify quickstart HTML template

mozilla / django-browserid

Django application for adding BrowserID support.

Mozilla Public License 2.0

180 stars 80 forks source link

Simplify quickstart HTML template #278

Closed toolness closed 9 years ago

toolness commented 9 years ago

This makes the quickstart HTML template use the browserid_css and browserid_js template tags, which is useful for a few reasons:

It simplifies the template code.
It allows the template to be copy-pasted into an empty file (the existing code is missing a {% load static %} but this change removes the need for that).
It makes the template work automatically with the auto-login system for offline development.

toolness commented 9 years ago

Oh, I guess I should also add that I've only tested this on Django 1.7.6... I guess I'm not sure if this works out-of-the-box in earlier versions of Django...

Osmose commented 9 years ago

Wow, how did we miss that? We should totally be using those tags in the quickstart. We do use them in the Jinja example, weird that we missed it here.

It should work fine on earlier versions. Travis is sad because apparently our .travis.yml file is trying to test Django 1.7 on Python 2.6, which isn't supported.

Thanks for the fix!

Osmose commented 9 years ago

r+wc, lemme know when you make that tweak and I'll merge!

(I'm also playing around with fixing the .travis.yml file, so hopefully once you make the change you can rebase on that and see the tests passing. :D)

toolness commented 9 years ago

Ah, thanks @Osmose! Ok, I removed the duplicate script tag so we should be good to go.