search

mozilla / django-product-details

Product and locale details for Mozilla products
https://product-details.mozilla.org/1.0/
BSD 3-Clause "New" or "Revised" License
27 stars 22 forks source link

Drop Python 2 support #78

Closed akatsoulas closed 2 years ago

stevejalim commented 2 years ago

Heya @akatsoulas - thanks for this. There's some parallel work going on to support FF 100+ and as part of that, I fixed travis (for now, but we're going to move it to GH Actions for CI instead, later). You might find that cherry picking these two commits off our 76-update-for-three-digit-versions branch will help you -- you can probably use them and then remove 2.x from the tox config

akatsoulas commented 2 years ago

Thanks for those commits @stevejalim. I basically removed the non supported versions of Python and Django which was way easier with your commits. In the second commit I used black as my editor auto-linted the files that I changed in the first commit. Happy to drop it if you prefer.

Unfortunately I was not able to add support for Python 3.10 b/c Travis does not support it. Maybe something to tackle with the move to GH Actions.

Finally, when this PR passes the review would it be possible to merge it? I am updating sumo to Django 3.2 and this lib is in the critical path. Thanks!

stevejalim commented 2 years ago

Heya @akatsoulas - all sounds good to me and no objection to black at all. Thanks for the work!

I think we won't be getting bedrock to 3.10 just yet, and will wait for the ecosystem to catch up a little first anyway.

Let me know if you want me to review, else am sure pmac will be happy to

akatsoulas commented 2 years ago

Feel free to review if you have the bandwidth! Thanks!

stevejalim commented 2 years ago

Heads up to @robhudson that this PR will likely move some of the ground beneath the FX100 branch we also have in parallel. I won't rebase that branch myself in case it messes with your stuff, Rob, but happy to chat about it