search

mozilla / django-product-details

Product and locale details for Mozilla products
https://product-details.mozilla.org/1.0/
BSD 3-Clause "New" or "Revised" License
27 stars 22 forks source link

Update tox matrix versions #91

Open janbrasna opened 4 months ago

janbrasna commented 4 months ago

Testing only Python versions 3.9–3.11 and Django 3.2+, 4.0.x, 4.2.x and 5.0.x ✅

(To support Python 3.12 a refactor is in the cards unfortunately, migrating away from imp, therefore replacing nose with nose2 or pynose or pytest)

janbrasna commented 4 months ago

BTW if/when refactoring for 3.12 you also might want to get rid the separate GHA matrix config in ci.yml that needs keeping in sync with tox.ini, in favour of e.g. tox-gh-actions to simplify maintenance.

Question here is whether you'd like the classifier versions: https://github.com/mozilla/django-product-details/blob/228b14cb46c8903ef3b4c2460e352d69cc67049c/setup.py#L40-L43 in sync with the versions being in the test matrix now (even that lower/higher might actually be compatible?) — i.e. drop the older Pythons somewhat officially if there are tests no longer ensuring compatibility… I'm only not sure whether that wouldn't warrant a release(?) Feel free to amend the dependencies as you see fit, I'd rather not touch these (only wanted to have more current tests without rewriting).