Model config file setup

mozilla / docker-etl

Collection of dockerized ETL jobs managed by data engineering.

Mozilla Public License 2.0

19 stars 15 forks source link

Model config file setup #171

Closed m-d-bowerman closed 9 months ago

m-d-bowerman commented 9 months ago

Checklist for reviewer:

[ ] Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title)
[ ] Scan the PR and verify that no changes (particularly to .circleci/config.yml) will cause environment variables (particularly credentials) to be exposed in test logs
[ ] Ensure the container image will be using permissions granted to telemetry-airflow responsibly.

jmsilverman commented 9 months ago

There's a lot of KPI Forecasting related stuff in here so I'd request that @bochocki and @bani take a look as well!

m-d-bowerman commented 9 months ago

There are a few issues in the utils tests and a bug in one of the util functions. As for the Prophet setups, I'm not super familiar with how those work but @bochocki definitely is, so we should get his eyes on this!

I pushed these by accident before logging off yesterday 🤦 . Thanks for being thorough with your review and catching all this! I'll fix them this morning.

jmsilverman commented 9 months ago

Tests look good to me now!