search

mozilla / docker-etl

Collection of dockerized ETL jobs managed by data engineering.
Mozilla Public License 2.0
19 stars 15 forks source link

feat:[ASP-4545] Workday - XMatters integration #199

Closed JCMOSCON1976 closed 5 months ago

JCMOSCON1976 commented 5 months ago

This PR is to push the scripts that synchronize employee data from Workday to the XMatters system.

We are moving this code from https://github.com/mozilla-it/data-integrations to docker-etl

JIRA TICKET ASP-4545 JIRA EPIC TICKET ASP-4509

JCMOSCON1976 commented 5 months ago

Hi @JCMOSCON1976 , Two things - 1.Are the test cases limited to what you have in the "test_main.py" or do you plan to add more when merged with prod? 2. I vaguely remember that mapping phone details from workday to Xmatters was also part of the reqt. Can you confirm if this is needed/added in the current code?

Thanks Hi Shraddha, answering your questions: 1) this is an old code, and we are not adding test code for it now. We will only move the code to this new location and add a feature that they wanted. 2) we will discuss this with the Mozilla/XMatters team in a future iteration.

spatilmoz commented 5 months ago

Hi @JCMOSCON1976 , Two things - 1.Are the test cases limited to what you have in the "test_main.py" or do you plan to add more when merged with prod? 2. I vaguely remember that mapping phone details from workday to Xmatters was also part of the reqt. Can you confirm if this is needed/added in the current code? Thanks Hi Shraddha, answering your questions:

1. this is an old code, and we are not adding test code for it now. We will only move the code to this new location and add a feature that they wanted.

2. we will discuss this with the Mozilla/XMatters team in a future iteration.

Thanks for clarifying @JCMOSCON1976 . Approving the review.