Support importing CrUX data into webcompat kb

mozilla / docker-etl

Collection of dockerized ETL jobs managed by data engineering.

Mozilla Public License 2.0

19 stars 15 forks source link

Support importing CrUX data into webcompat kb #298

Closed jgraham closed 1 week ago

jgraham commented 2 weeks ago

Checklist for reviewer:

[ ] Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title)
[ ] Scan the PR and verify that no changes (particularly to .circleci/config.yml) will cause environment variables (particularly credentials) to be exposed in test logs
[ ] Ensure the container image will be using permissions granted to telemetry-airflow responsibly.

jgraham commented 1 week ago

Not sure if that's expected

No, that was me not understanding the argparse API correctly :) I added some custom logic to get the behaviour I wanted (no arguments runs all jobs, but if jobs are supplied they have to be one of the provided ones).

ksy36 commented 1 week ago

It works as expected now, thanks for working on this :)

@scholtzan wonder if could you merge this PR as well, please?