search

mozilla / doh-rollout

DEPRECATED - Add on for initial DoH rollout
Mozilla Public License 2.0
7 stars 4 forks source link

de-dup network change api #167

Closed mixedpuppy closed 4 years ago

mixedpuppy commented 4 years ago

https://github.com/mozilla/doh-rollout/blob/8ffa1ad1f6123621bf6cb7e6ca356e8139e2654e/src/experiments/netChange/api.js#L29

What specifically about the networkStatus API cannot work for the doh-rollout?

https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-networkStatus.js

If there are problems with the implementation available I'd like to see some bugzilla bugs with details so we can address them.

nhi-nguyen commented 4 years ago

IIRC, the networkStatus API landed in 70. We needed something that worked on 69 as well.

mixedpuppy commented 4 years ago

That explains a lot. I'm still curious about the differences in the implementation. If the m-c implementation had been available, is it sufficient or do we need to make changes?

nhi-nguyen commented 4 years ago

cc @nhnt11

maxxcrawford commented 4 years ago

This has been resolved in-tree. @nhnt11 Can you confirm?

nhnt11 commented 4 years ago

Yup, resolved in m-c.