The DoH doorhanger is not displayed again after reopening the tab on which it was previously triggered

[SoftVision-CarmenFat]

[Affected Platforms]:

• All Windows

[Affected Versions]:

• Firefox Release 70.0.1, Build ID 20191030021342

[Prerequisites]:

• Have an active Normandy testing recipe for DoH.
• You are enrolled in the Treatment branch.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Close the tab where the DoH doorhanger is displayed.
3. Reopen the previosuly closed tab and observe the behavior.

[Expected result]:

• The tab is reopened and the DoH doorhanger is displayed again.

[Actual result]:

• The tab is reopened but the DoH doorhanger is no longer displayed.

[Notes]:

• According to this comment, the doorhanger should continue to be triggered unless the user does any of the following actions:
  • Clicks okay
  • Clicks disable protections
  • Clicks "esc" key while its in focus (triggers an okay click)
• The issue is reproducible with the 1.1.0rc1 version of the add-on.
• I have attached a screen recording of the issue:

[maxxcrawford]

Once the doorhanger is removed from the current context (Tab close is an example of this), it won't show again until network change or browser restart.

This is expected behavior, I believe.

@nhi-nguyen Thoughts?

[SoftVision-CarmenFat]

Actually, on browser restart, the doorhanger is displayed again. This only happens when reopening the tab.

[mythmon]

Since the tab isn't (logically) associated with that particular tab, it seems that it shouldn't be affected by that tab closing. I realize that in the code the doorhanger is related to a particular tab, but that isn't something that is consistent with the message we are trying to send, since the message is about the browser, not a tab.

[nhi-nguyen]

Agree that the doorhanger isn't associated with a particular tab, and its behaviour should reflect that. However, this is the way it is currently implemented, and the reported behaviour is consistent with how it currently works.

This is an issue, but not a blocking one for this release. It will be done for https://github.com/mozilla/doh-rollout/issues/158, which will be in v1.3.

[maxxcrawford]

Bug filed: https://bugzilla.mozilla.org/show_bug.cgi?id=1605009