Fixed #190 - Added logic to enable add-on based on local storage migration values - Githubissues

mozilla / doh-rollout

DEPRECATED - Add on for initial DoH rollout

Mozilla Public License 2.0

7 stars 4 forks source link

Fixed #190 - Added logic to enable add-on based on local storage migration values #191

Closed maxxcrawford closed 4 years ago

maxxcrawford commented 4 years ago

To verify:

Scenarios

A. DoH turned on, user did not interact with doorhanger
B. DoH turned on, user clicked “Enable” on doorhanger
C. DoH turned on, user clicked “Enable” on doorhanger, network changed, turning DoH off
D. DoH turned off, user clicked “Disabled” on doorhanger

1. Setup v1.0.4 Add-on

Install v1.0.4 add-on (Signed XPI)
Verify v1.0.4 via about:support
- Listed under “extensions”
In about:config
- Add boolean pref doh-rollout.enabled set to true
- Optional: Add boolean pref doh-rollout.debug set to true

2. Remove v1.0.4 Add-on

Go to about:config, and reset doh-rollout.enabled pref
Go to about:profiles, go to local directory of active profile
Quit browser
Delete /extensions folder
Restart browser
Verify via about:support that DoH is no longer listed
Verify that network.trr.mode is set to 2
Verify add-on has set local storage items
Go to: about:devtools-toolbox?type=extension&id=doh-rollout%40mozilla.org*
Run the following command:

await browser.storage.local.get()

Expected responses:

Scenario	Response
A	`{ "doh-rollout.previous.trr.mode": 2, doneFirstRun: true, skipHeuristicsCheck: false }`
B	`{ "doh-rollout.doorhanger-decision": "UIOk", "doh-rollout.doorhanger-ping-sent": true, "doh-rollout.doorhanger-shown": true, "doh-rollout.previous.trr.mode": 2, doneFirstRun: true, skipHeuristicsCheck: false }`
C	`{ "doh-rollout.doorhanger-decision": "UIOk", "doh-rollout.doorhanger-ping-sent": true, "doh-rollout.doorhanger-shown": true, "doh-rollout.previous.trr.mode": 0, doneFirstRun: true, skipHeuristicsCheck: false }`
D	`{ "doh-rollout.disable-heuristics": true, "doh-rollout.doorhanger-decision": "UIDisabled", "doh-rollout.doorhanger-ping-sent": true, "doh-rollout.doorhanger-shown": true, "doh-rollout.previous.trr.mode": 5, doneFirstRun: true, skipHeuristicsCheck: false }`

*If the above does not work, do the following:

Turn pref devtools.aboutdebugging.showHiddenAddons to true
Go to about:debugging#/runtime/this-firefox
Scroll to the bottom of the Extensions list
Click “inspect” button on DoH Roll-Out add-on
Expected: Open console for add-on code. Run the snippet mentioned above here.

3. Install v1.2.0rc1 Add-on

Install v1.1.2rc2 add-on (Signed XPI)
Verify add-on in about:support, listed under “extensions”
Scenario expectations table:

Scenario	Prefs	Doorhanger Behavior
A	`doh-rollout.balrog-migration-done;true` `doh-rollout.doneFirstRun;true` `doh-rollout.previous.trr.mode;2` `doh-rollout.self-enabled;true` `doh-rollout.skipHeuristicsCheck;false`	Should be visible
B	`doh-rollout.balrog-migration-done;true` `doh-rollout.doneFirstRun;true` `doh-rollout.doorhanger-decision;UIOk` `doh-rollout.doorhanger-shown;true` `doh-rollout.previous.trr.mode;2` `doh-rollout.self-enabled;true` `doh-rollout.skipHeuristicsCheck;false`	Should be hidden
C	`doh-rollout.balrog-migration-done;true` `doh-rollout.doneFirstRun;true` `doh-rollout.doorhanger-decision;UIOk` `doh-rollout.doorhanger-shown;true` `doh-rollout.previous.trr.mode;2` `doh-rollout.self-enabled;true` `doh-rollout.skipHeuristicsCheck;false`	Should be hidden
D	`doh-rollout.balrog-migration-done;true` `doh-rollout.disable-heuristics;true`	Should be hidden

If self-enabled is set to true, continue with additional testing to verify add-on is behaving as expected.
If debug logging is set to true, see those logs at about:devtools-toolbox?type=extension&id=doh-rollout%40mozilla.org