search

mozilla / doh-rollout

DEPRECATED - Add on for initial DoH rollout
Mozilla Public License 2.0
7 stars 4 forks source link

Telemetry event shows "evaluateReason": "userModified" instead of "evaluateReason": "startup" #202

Closed cbaica closed 4 years ago

cbaica commented 4 years ago

[Affected Platforms]: Windows 10x64 Windows 7x64 macOS 10.15 Ubuntu 18.04x64

[Affected Versions]: Firefox Release 70.0.1 Firefox Beta 71.0b12 Firefox Nightly 72.0a1

[Prerequisites]: Have the DoH addon/recipe active and enabled (doh-rollout.enabled = true).

[Steps to reproduce]:

  1. Open the browser, go to about:preferences, search for the "Network Settings" option and disable the "Dns over HTTPS" option.
  2. Restart the browser (open console then CTRL+ALT+R).
  3. Go to about:telemetry#events tab and investigate the dynamic event, the extra content column.

[Expected result]: The evaluateReason value is listed as "startup".

[Actual result]: The evaluateReason value is "userModified".

[Notes]: The issue is reproducible with the 1.2.0rc2 version of the add-on. image

maxxcrawford commented 4 years ago

This is expected — user modified means that the user has made a choice to enable/disable DoH separate from the add-on, and the add-on will be disabled.

cc/ @nhi-nguyen

maxxcrawford commented 4 years ago

@nhi-nguyen Should this be ported over? I think this is expected behavior right now.

nhi-nguyen commented 4 years ago

@maxxcrawford we don't need to port this issue.