search

mozilla / elasticutils

[deprecated] A friendly chainable ElasticSearch interface for python
http://elasticutils.rtfd.org
BSD 3-Clause "New" or "Revised" License
243 stars 76 forks source link

Allow to change size of facet results #146

Closed eire1130 closed 11 years ago

eire1130 commented 11 years ago

I have a branch here: https://github.com/eire1130/elasticutils/tree/size_matters

take a look at it, if you like the methodology, I'll send the pull request (and change the docs).

The size argument needs to be nested inside the term of the facet. Default is normally 10.

willkg commented 11 years ago

I'm not wildly excited about this method. Seems like it's introducing arguments at the wrong point of the API.

Right now the facets support is pretty meh and has a lot of API problems. I redid the filter and query implementations to be more extensible. The facet implementation requires something similar. I think that really needs a bigger rethinking and I'm kind of loathe to patch the existing implementation because it creates additional things we have to work around when doing a rethinking.

Issue #73 sort of covers the overhaul. We should take this conversation there.