search

mozilla / elasticutils

[deprecated] A friendly chainable ElasticSearch interface for python
http://elasticutils.rtfd.org
BSD 3-Clause "New" or "Revised" License
243 stars 76 forks source link

Remove Pinning on Pyelasticsearch==0.6 #183

Closed kevinastone closed 10 years ago

kevinastone commented 10 years ago

Pyelasticsearch==0.6.1 allows requests>=2.0. Hard to imagine it will break elasticutils. Please use a ">=" to allow future updates.

willkg commented 10 years ago

Have you run the tests with that version of pyelasticsearch?

The reason I pinned to a specific version is that pyelasticsearch periodically does backwards incompatible changes like moving arguments around and that's bit me a couple of times now.

kevinastone commented 10 years ago

Including minor releases like 0.6.0 -> 0.6.1?

Yes, I ran the test suite successfully against pyelasticsearch==0.6.1.

# python run_tests.py 
.........................................................................................................................................................
----------------------------------------------------------------------
Ran 153 tests in 14.640s

OK
willkg commented 10 years ago

I just merged a big change to switch to elasticsearch-py. That nixes the need to do this, so I'm closing it out now.

kevinastone commented 10 years ago

Makes sense. Is there a release plan and version number for this change to prepare?

willkg commented 10 years ago

I'm doing a 0.8.2 release and will fix setup.py to allow pyelasticsearch 0.6.1, too. pyelasticsearch isn't undergoing much development right now, so this should last us a while.