search

mozilla / elasticutils

[deprecated] A friendly chainable ElasticSearch interface for python
http://elasticutils.rtfd.org
BSD 3-Clause "New" or "Revised" License
243 stars 76 forks source link

Support Minimum Version Checks in Unit Tests #201

Closed kevinastone closed 10 years ago

kevinastone commented 10 years ago

I ended up not using this for the unit test I submitted with #197, but with ElasticSearch continuing to add new features, I thought future tests would benefit with a way to specify the minimum version of the elastic search server required for the test.

willkg commented 10 years ago

This is awesome. Thank you!

willkg commented 10 years ago

I couldn't automatically merge it because I had made a change yesterday to refresh which is just before the changes, so I instead cherry-picked it into master.

fe58a3b Added version check for unit tests.

willkg commented 10 years ago

Bah... There was a decorator version in pull #185. So I grabbed that one and backed this one out. Sorry about that.

kevinastone commented 10 years ago

Cool. I thought a decorator might work more appropriately anyways.