search

mozilla / elasticutils

[deprecated] A friendly chainable ElasticSearch interface for python
http://elasticutils.rtfd.org
BSD 3-Clause "New" or "Revised" License
243 stars 76 forks source link

Compatibility with elasticsearch 1.0 #203

Closed honzakral closed 10 years ago

honzakral commented 10 years ago

With 1.0 elasticsearch has deprecated text queries that elasticutils uses and the official client is split into two branches (and corresponding releases) - fixed the code and added docs on which version to choose.

honzakral commented 10 years ago

Added the deprecation info to CHANGELOG and code.

willkg commented 10 years ago

We had a long talk and decided ElasticUtils 0.9 will only support Elasticsearch 0.90 and lower. I'm going to finish up the work and release it ASAP.

Then the next version of ElasticUtils will support Elasticsearch 0.90 and 1.0 and we'll drop support for versions of Elasticsearch prior to 0.90. That'll make some of this code easier and reduce the combination of things we're testing.

simon-weber commented 10 years ago

What's the roadmap for 1.0 support look like? We're looking to roll out a Django + ES 1.0, and I'd prefer not to reimplement the Django ORM integration =)

setup.py is declares that elasticsearch-py < 1.0 is required, but this PR makes it look like things are mostly compatible. Is that the case?

willkg commented 10 years ago

I just pushed out 0.9 followed by a 0.9.1 today.

Several of us are meeting at PyCon this week and will sprint on ElasticUtils next week and figure out the big plan. Maybe even get some stuff done. If you're going to be at PyCon during the sprint days, feel free to join us!

simon-weber commented 10 years ago

Groovy. I won't be at PyCon but a bunch of my coworkers will be -- maybe some of them will join you =)

honzakral commented 10 years ago

I will definitely be there and will be happy to help with porting and testing.

rouge8 commented 10 years ago

Any chance of this or something similar being merged soon?

willkg commented 10 years ago

ElasticUtils 0.10 will require Elasticsearch 0.90 or later. Given that, I'm going to close this out and instead remove all the text* support with a big backwards-incompatible note in the CHANGELOG.