mozilla / elasticutils

[deprecated] A friendly chainable ElasticSearch interface for python
http://elasticutils.rtfd.org
BSD 3-Clause "New" or "Revised" License
243 stars 76 forks source link

Do not set facet_filter if there is no filter. #217

Closed mihneadb closed 10 years ago

mihneadb commented 10 years ago

I stumbled across this issue when calling .facet(..., filtered=True) on a query that did not have a filter. I'd say that the API should be robust and accept this usecase, especially since you can set up a pipeline that chains various calls on an S() object and ends up calling facet on it.

willkg commented 10 years ago

Whoops! Thank you for this!