Closed willkg closed 10 years ago
Putting this in the 0.9 milestone because feature creep is teh awesome.
+1. I use _build_query a lot. I was going to send a PR for making it public and then also wrapping a to_json method as well.
I hadn't thought about a to_json
method. What's the use case for converting it to JSON?
A couple of reasons:
json.dumps(es._build_query())
. I then take that off to head plugin and tinker with my query there.It's not a big deal really to not have it, and it might not be worth the effort. You'd have to use the serializer in py-elasticsearch.
Landed!
Right now
_build_query
is a "private" method. We should:_
build_search
Why?
It's super helpful to have. Plus it lets people use S solely for building searches to use with other things rather than executing the S.