Change S._build_query() to S.build_search()

[willkg]

• make _build_query public (and change the name)
• add to_json utility function
• add tests for to_json
• add documentation for utility functions

r?

[willkg]

@eire1130: Does this work for you?

@robhudson: Can you review this? It should be pretty straight forward: name change, some tweaks to documentation, new to_json function and that's about it.

[eire1130]

pretty cool to me. Is there merit for .build_search() to call ._build_query()?

[robhudson]

The change looks good to me. I asked a few questions, otherwise :shipit:.

[willkg]

@eire1130 There is no more _build_query(). I tossed around whether to have a _build_query() that calls build_search(), but I don't think it's worth the maintenance baggage.

[willkg]

I think this is good. I'll wait until tomorrow to land it in case there are other thoughts/objections/etc.

[willkg]

Landed! Thank you!