Closed willkg closed 10 years ago
@eire1130: Does this work for you?
@robhudson: Can you review this? It should be pretty straight forward: name change, some tweaks to documentation, new to_json function and that's about it.
pretty cool to me. Is there merit for .build_search()
to call ._build_query()
?
The change looks good to me. I asked a few questions, otherwise :shipit:.
@eire1130 There is no more _build_query()
. I tossed around whether to have a _build_query()
that calls build_search()
, but I don't think it's worth the maintenance baggage.
I think this is good. I'll wait until tomorrow to land it in case there are other thoughts/objections/etc.
Landed! Thank you!
r?